Sepolia testnet in the SDK #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are slowly moving to our new Sepolia testnet. Contracts are already deployed there. It is a good time to add Sepolia testnet support to the SDK.
michalsmiarowski
approved these changes
Nov 14, 2023
Comment on lines
+77
to
+80
| /** | ||
| * Initializes the tBTC v2 SDK entrypoint for Ethereum Sepolia and Bitcoin testnet. | ||
| * The initialized instance uses default Electrum servers to interact | ||
| * with Bitcoin testnet |
There was a problem hiding this comment.
Non-blocking, but the way we wrap those comments looks odd. The first line does not break at 80 characters and the second line breaks too early 🤔 I've got a margin set in my IDE at 80 characters and you can see it clearer on the image below:
I think the ideal scenario would be to keep the margin for comments at 80 characters, just like it is for the code:
Either
or
The same thing is happening for initializeEthereum and initializeGoerli functions docs.
Just pointing that out. I'm not gonna block the merge because of that 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: threshold-network/solidity-contracts#150
We are slowly moving to our new Sepolia testnet. Contracts are already deployed there. It is a good time to add Sepolia testnet support to the SDK.
Artifacts were taken from the following npm packages:
@keep-network/tbtc-v2@sepolia@keep-network/ecdsa@sepolia