Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: claim button and menu diviver theme colors #230

Conversation

lauchaves
Copy link
Contributor

@lauchaves lauchaves commented Jul 21, 2024

Description

Implementation

  • Updated theme colors for better readability and consistency.

Screenshots

Claim dark issue
claim dark

menu divider too dark
image

menu fix
image

claim button text on dark theme is white now, didn't have tips to show it but is fixed now! :D

Copy link

vercel bot commented Jul 21, 2024

Someone is attempting to deploy a commit to the keep-starknet-strange Team on Vercel.

A member of the Team first needs to authorize it.

@lauchaves
Copy link
Contributor Author

JM! @maciejka @MSghais This one is ready for review!

@ugur-eren ugur-eren self-requested a review July 22, 2024 01:30
Copy link
Collaborator

@ugur-eren ugur-eren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I've requested a single change

JoyboyCommunity/src/components/Menu/styles.ts Outdated Show resolved Hide resolved
@lauchaves lauchaves force-pushed the fix-claim-button,menu-divider-theme-colors branch from a4ee660 to dbecfee Compare July 23, 2024 03:40
@lauchaves lauchaves requested a review from ugur-eren July 23, 2024 03:50
@ugur-eren ugur-eren merged commit bcf4927 into keep-starknet-strange:main Jul 23, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants