Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: show tip in user profile #235

Merged
merged 3 commits into from
Jul 23, 2024

Conversation

MSghais
Copy link
Collaborator

@MSghais MSghais commented Jul 22, 2024

Fix:

Click on Tip in the User profile to open the Tip modal
Adding a show tip modal with only a user public key (no event in Profile/Info) to open the modal

image

image

Reported in #233

Copy link

vercel bot commented Jul 22, 2024

@MSghais is attempting to deploy a commit to the keep-starknet-strange Team on Vercel.

A member of the Team first needs to authorize it.

@MSghais MSghais requested a review from ugur-eren July 22, 2024 00:51
@ugur-eren
Copy link
Collaborator

ugur-eren commented Jul 22, 2024

Why not just use the current logic, and use {pubkey: publicKey} for the event? Content will be empty, and all pubkey logic will still work as expected

@ugur-eren ugur-eren merged commit 0dc954e into keep-starknet-strange:main Jul 23, 2024
4 of 6 checks passed
@ugur-eren ugur-eren linked an issue Jul 24, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix hard coded likes amount
2 participants