feat: Validate coinbase outputs

[manlikeHB]

• issue [feat] Validate coinbase outputs #140
• follows contribution guide
• code change includes tests

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
raito	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 14, 2024 10:25am

[m-kus]

@manlikeHB the task also includes calculating the wtxid commitment.
There is already wtxid merkle root calculated (see compute_and_validate_tx_data), the algorithm for calculating the commitment described in https://learnmeabitcoin.com/technical/transaction/wtxid/#commitment

Add unit tests to ensure that txid commitment is calculated correctly

[manlikeHB]

@m-kus, Is there a way I can get minimal/test blocks with segwit transactions to test the correctness of the wtxid commitment being calculated?

[m-kus]

@m-kus, Is there a way I can get minimal/test blocks with segwit transactions to test the correctness of the wtxid commitment being calculated?

There is now full_757738 test which applies a block with segwit transactions in main, you just need to rebase.
You can also take some data from it for a unit test.

[maciejka]

@m-kus @maciejka, I feel the issue I am facing is not from the validate_coinbase function because the unit test passes in test_validate_coinbase_with_segwit_tx test using mock coinbase transaction data and a pre-calculated wtxid root hash.

I am trying to debug but that's a bit hard since I can't log/print values to the terminal while running the integration test.

Hi, it is difficult to debug indeed. I pushed a fix to print test output. You should be able to debug it now. Don't hesitate to ask for help if you feel blocked next time!