[feat] P2PK transaction support

[b-j-roberts]

Currently, all the opcodes for P2PK are implemented. To ensure we support all P2PK transactions/formats, we will need to create a set of tests for these transaction types and ensure all the logic and edge cases are handled properly. Also, including a P2PK transaction from mainnet as a test would be ideal.

References

learn P2PK & examples
example crypto tests

[b-j-roberts]

@ptisserand Thank you for looking into this!

[ptisserand]

@b-j-roberts could you please assign to me ?

[mubarak23]

@b-j-roberts let work on this since it is related to my previous issue

[ScottyDavies]

@b-j-roberts can I please be assigned this task?

[bloomingpeach]

Hi seems @ptisserand is quite busy working on other projects, could I have a chance to work on this @b-j-roberts if it's okay. Thanks!

[b-j-roberts]

@bloomingpeach Sure, feel free to take a look. Thank you!

Some changes have been made since creating this issue, I'd recommend looking at this P2PK test for direction. Feel free to let me know if it isn't fully clear.

shinigami/src/tests/test_transactions.cairo

Line 73 in 6496bc1

fn test_validate_transaction() {

I'd recommend creating test cases from all the transactions mentioned in the learnmebitcoin article and a couple other random ones from mainnet. ( if / when you have time )

[bloomingpeach]

Hi @b-j-roberts where could i learn more about the utxo_hints(https://github.com/keep-starknet-strange/shinigami/blob/6496bc124167658168f9e2835b58534967240ff3/src/tests/test_transactions.cairo#L80C5-L87C39), I don't quite see the term anywhere.

[b-j-roberts]

Hi @b-j-roberts where could i learn more about the utxo_hints(https://github.com/keep-starknet-strange/shinigami/blob/6496bc124167658168f9e2835b58534967240ff3/src/tests/test_transactions.cairo#L80C5-L87C39), I don't quite see the term anywhere.

So the utxo_hint term is just a term I coined, so probably wont be info anywhere. But essentially, the utxo_hints contain all the old valid transaction utxos that will be used to process that transaction.
So for the example in the linked test, you can see the transaction has one input.

That input corresponds to an old output utxo from transaction 0437cd7f8525ceed2324359c2d0ba26006d92d856a9c20fa0241106ee5a597c9.

So if you look at output 0 from that transaction that will represent the utxo_hint used to process the transaction.