Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wip: add p2pk tests #209

Merged
merged 6 commits into from
Sep 17, 2024
Merged

wip: add p2pk tests #209

merged 6 commits into from
Sep 17, 2024

Conversation

bloomingpeach
Copy link
Contributor

@bloomingpeach bloomingpeach commented Sep 11, 2024 •
edited
Loading

@vercel Vercel
Copy link

vercel bot commented Sep 11, 2024

@bloomingpeach is attempting to deploy a commit to the keep-starknet-strange Team on Vercel.

A member of the Team first needs to authorize it.

b-j-roberts
b-j-roberts approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@b-j-roberts b-j-roberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll go ahead and merge now, thank you for looking into this and building the tests!

@b-j-roberts b-j-roberts marked this pull request as ready for review September 17, 2024 05:18
@b-j-roberts b-j-roberts merged commit 9c88b0e into keep-starknet-strange:main Sep 17, 2024
3 of 4 checks passed
@b-j-roberts b-j-roberts mentioned this pull request Sep 17, 2024
Merged
3 tasks
j1mbo64 pushed a commit to j1mbo64/shinigami that referenced this pull request Sep 18, 2024
@bloomingpeach @b-j-roberts
wip: add p2pk tests (keep-starknet-strange#209)
44a90e5 
<!-- enter the gh issue after hash -->

- [ ] Fixes keep-starknet-strange#183 
- [ ] follows contribution
[guide](https://github.com/keep-starknet-strange/shinigami/blob/main/CONTRIBUTING.md)
- [ ] code change includes tests

<!-- PR description below -->

---------

Co-authored-by: Brandon Roberts <brandonjroberts22@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b-j-roberts b-j-roberts b-j-roberts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feat] P2PK transaction support
2 participants
@bloomingpeach @b-j-roberts