Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce log spam #360

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Reduce log spam #360

wants to merge 3 commits into from

Conversation

notlesh
Copy link
Collaborator

@notlesh notlesh commented Sep 6, 2024 •
edited
Loading

Problem: printing all storage keys is noisy

Solution: remove log statement

Issue Number: N/A

Type

  • feature
  • bugfix
  • dev (no functional changes, no API changes)
  • fmt (formatting, renaming)
  • build
  • docs
  • testing

Description

Breaking changes?

  • yes
  • no

@odesenfans
Copy link
Collaborator

I'm okay with this PR, however these logs have been super useful when debugging complex issues. Let's keep it on hold for now, until we resolve the last "Edge not found in preimage" errors.

@notlesh
Copy link
Collaborator Author

notlesh commented Sep 6, 2024

I'm okay with this PR, however these logs have been super useful when debugging complex issues. Let's keep it on hold for now, until we resolve the last "Edge not found in preimage" errors.

Sounds good, I could alternatively be happy with reducing them to log::trace() for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odesenfans odesenfans Awaiting requested review from odesenfans odesenfans is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@notlesh @odesenfans