Fix a couple more Qt 5.15 deprecation warnings #10953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addendum to 32ac59e post keepassxreboot#7783 merge (needed due to subsequent commits).
Similar to 7458712 from keepassxreboot#7783 (needed due to subsequent commits).
|
dang missed those |
droidmonkey
approved these changes
Jun 22, 2024
pull bot
pushed a commit
to tigerwill90/keepassxc
that referenced
this pull request
Jun 23, 2024
* More {QString->Qt}::SkipEmptyParts
* QProcess::start: non-deprecated overload
BryanJacobs
added a commit
to BryanJacobs/keepassxc
that referenced
this pull request
Jul 26, 2024
* upstream/develop: (57 commits) Fix typos in tooltips from EditEntryWidgetBrowser.ui Refactor: separate GUI sources from core sources Database key settings: fix UI bug tests: gui: Fix NULL dereference in GUI tests Docs: explain how to generate passwords with the browser extension (keepassxreboot#9242) Fix a couple more Qt 5.15 deprecation warnings (keepassxreboot#10953) Update URLs to Chrome Web Store page for `KeePassXC-Browser` extension Update browser extension icon states in documentation (keepassxreboot#10875) Fix сentering icon and text on buttons Fix backup file path substitution Verify USB listener callback handle Refactor Database Settings (keepassxreboot#9485) Fix all Qt 5.15 deprecation warnings (keepassxreboot#7783) Passkey importer: fix file picker parent Require Qt >= 5.12 Passkeys: Fix showing correct username in the reports Show character count in password generator dialog (keepassxreboot#10940) Increase the time interval for window show workaround Snap: Remove $HOME access from keepassxc-proxy Correct libusb usage on FreeBSD (keepassxreboot#10736) ... # Conflicts: # src/CMakeLists.txt # src/core/Database.cpp # src/core/Database.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addendum to #7783. Needed due to commits made subsequently to the most recent update to that PR.
To prevent future regressions, I would suggest building with
-DWITH_DEV_BUILD=ON(ideally against Qt 5.15) during CI.Testing strategy
Compiles successfully with
-DWITH_DEV_BUILD=ON.Unit tests pass successfully.
Type of change