Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: move to simple default builds #11003

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Refactor: move to simple default builds #11003

wants to merge 2 commits into from
+698 −1,093

Commits on Jul 28, 2024

  1. Refactor: Move to simple default builds 

    * Remove individual feature flags in favor of a single `KPXC_MINIMAL` flag that removes advanced features from the build. Basic features are no longer guarded by feature flags.
* Basic features: Auto-Type, Yubikey, KeeShare
* Advanced features include: Browser (and passkeys), SSH Agent, and Secret Service
* Networking, Documentation, and Update Checking remain as feature flags to accommodate various distro requirements.

This change also cleans up the main CMakeLists.txt by re-arranging some content and placing macros into a dedicated include file. The minimum CMake version was bumped to 3.16.0 to conform to our minimum Ubuntu support of Focal (20.04). This also allows us to default to C++20, we fall back to C++17 for Qt versions less than 5.15.0 due to lack of support.

Lastly this change removes the KEEPASSXC_BUILD_TYPE="PreRelease" which is never used. We only support "Snapshot" and "Release" now.
    @droidmonkey
    droidmonkey committed Jul 28, 2024
    Configuration menu
    Copy the full SHA
    a5af525 View commit details
    Browse the repository at this point in the history

  2. Remove version minimum on X11 extras 

    Co-authored-by: Carlo Teubner <carlo@cteubner.net>
    @droidmonkey @c4rlo
    droidmonkey and c4rlo committed Jul 28, 2024
    Configuration menu
    Copy the full SHA
    76624f6 View commit details
    Browse the repository at this point in the history