Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor style fixes #11445

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

xboxones1
Copy link
Contributor

@xboxones1 xboxones1 commented Nov 7, 2024

  • Clean up removed elements
  • Removed widgets for which you don't need to change the color
  • Fix scrollbar groove color when disabled

Screenshot

Before. This is what it looks like if we don't change the color for DatabaseWidget #groupView, DatabaseWidget #tagView when they are disabled. Without fixing the scrollbar.
before
After. With the scrollbar fix
after

Testing strategy

Manually

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

@xboxones1
Copy link
Contributor Author

xboxones1 commented Nov 7, 2024

Or leave it the way it is now? This is how it looks when we change the color for DatabaseWidget #groupView, DatabaseWidget #tagView when they are disabled. Style customization in QT is complicated.

382577698-3e4a82de-3137-4224-84c2-4276678f5f18

@droidmonkey
Copy link
Member

I like the After on your initial post the best, so your proposed change should be applied.

@droidmonkey droidmonkey added this to the v2.7.10 milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants