-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SIARDDK support #625
Merged
Merged
SIARDDK support #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntonioG70
force-pushed
the
alindo-dev-virtualTable
branch
from
September 19, 2024 08:40
32db6f6
to
db64a95
Compare
AntonioG70
force-pushed
the
alindo-dev-virtualTable
branch
from
October 15, 2024 09:18
627f938
to
71a141e
Compare
006627
requested changes
Oct 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot of code is repeated due to the SIARD DK version separation, please review and apply best practices to ensure good code quality, I will finish reviewing this PR when you have these changes ready.
dbptk-core/src/test/java/com/databasepreservation/siarddk/SIARDDKTestUtil.java
Show resolved
Hide resolved
dbptk-core/src/test/java/com/databasepreservation/testing/integration/siard/SiardDKTest.java
Outdated
Show resolved
Hide resolved
dbptk-core/src/test/java/com/databasepreservation/testing/integration/siard/SiardTest.java
Outdated
Show resolved
Hide resolved
dbptk-core/src/test/java/com/databasepreservation/testing/integration/siard/SiardTest.java
Outdated
Show resolved
Hide resolved
dbptk-core/src/test/resources/siarddk/AVID.SA.18001.1/Indices/fileIndex.xml
Outdated
Show resolved
Hide resolved
...java/com/databasepreservation/modules/siard/in/path/ArchiveFileIndexInputStreamStrategy.java
Outdated
Show resolved
Hide resolved
.../main/java/com/databasepreservation/modules/siard/in/path/SIARDDK1007PathImportStrategy.java
Outdated
Show resolved
Hide resolved
...c/main/java/com/databasepreservation/modules/siard/in/path/SIARDDK128PathImportStrategy.java
Outdated
Show resolved
Hide resolved
...ava/com/databasepreservation/modules/siard/out/content/SIARDDK1007ContentExportStrategy.java
Outdated
Show resolved
Hide resolved
...m/databasepreservation/modules/siard/out/metadata/SIARDDK1007ContextDocumentationWriter.java
Outdated
Show resolved
Hide resolved
AntonioG70
force-pushed
the
alindo-dev-virtualTable
branch
2 times, most recently
from
October 25, 2024 09:24
f2a7ed5
to
a1747ec
Compare
AntonioG70
force-pushed
the
alindo-dev-virtualTable
branch
from
October 30, 2024 17:33
1a678f5
to
30d3019
Compare
AntonioG70
force-pushed
the
alindo-dev-virtualTable
branch
from
October 31, 2024 09:24
30d3019
to
117d673
Compare
AntonioG70
force-pushed
the
alindo-dev-virtualTable
branch
from
October 31, 2024 16:10
117d673
to
34a599a
Compare
006627
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.