Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update readme based on karet.util #410

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update readme based on karet.util #410

wants to merge 1 commit into from

Conversation

bpinto
Copy link
Contributor

@bpinto bpinto commented Nov 27, 2021 •
edited
Loading

Based on karet.util readme, this makes the readme bookmark friendly and includes a contents section.

You can see it here.

mAAdhaTTah
mAAdhaTTah reviewed Nov 28, 2021
View reviewed changes
Copy link
Contributor

@mAAdhaTTah mAAdhaTTah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this layout. We could move the plugin helpers documentation to kefir-test-utils and reference it from here, cuz we should share it with chai-kefir. Thoughts?

@bpinto
Copy link
Contributor Author

bpinto commented Nov 28, 2021 •
edited
Loading

What do you have in mind? To link plugin helpers to a specific commit readme on kefir-test-utils?

I've opened kefirjs/kefir-test-utils#369 on kefir-test-utils.

@bpinto
Copy link
Contributor Author

bpinto commented Jan 5, 2022

@mAAdhaTTah is now a good time to get back to these repositories changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mAAdhaTTah mAAdhaTTah mAAdhaTTah left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bpinto @mAAdhaTTah