fix: remove old workflows on addon checksum change #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccpeng
force-pushed
the
repeated-addon-stale-wf
branch
from
d5f5b80 to
ba9998b
Compare
Codecov Report
@@ Coverage Diff @@
## master #297 +/- ##
==========================================
- Coverage 56.20% 55.81% -0.39%
==========================================
Files 14 14
Lines 1893 1933 +40
==========================================
+ Hits 1064 1079 +15
- Misses 715 734 +19
- Partials 114 120 +6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ccpeng
force-pushed
the
repeated-addon-stale-wf
branch
from
ba9998b to
d81312e
Compare
Signed-off-by: Chun-Che Peng <chunche.peng@gmail.com>
ccpeng
force-pushed
the
repeated-addon-stale-wf
branch
from
d81312e to
206d8c1
Compare
Signed-off-by: Chun-Che Peng <chunche.peng@gmail.com>
ccpeng
changed the title
|
I think the Addon can still get stuck in pending if there's no further updates or controllers aren't updating... we can additionally add a check before return from addon-manager/controllers/addon_controller.go Line 350 in ef27eb5 |
ZihanJiang96
previously approved these changes
Oct 30, 2023
Signed-off-by: Chun-Che Peng <chunche.peng@gmail.com>
ZihanJiang96
approved these changes
Oct 30, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #285 #174
with contribution from @estela-ramirez
a new addon (but has the same checksum from recent past) won't generate a new workflow since a previous workflow was already created; as a result, the addon gets stuck on pending
fix is to purge old workflows so a new workflow can get created