Update hack directory with new CRD API #102
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kubernetes 1.22 deprecated the v1beta1 CRD API and replaced it with v1 CRD API. iam-manager's hack directory still uses the old API. Update that. Testing: Before this change, using ./hack/install broke the iam-manager controller install. After this change, ./hack/install works fine. Signed-off-by: Anusha Ragunathan <anusha.ragu@gmail.com>
anusha-ragunathan
changed the title
|
@anusha-ragunathan Can you also update the manifests to v1 version? I was doing similar stuff on my PR https://github.com/keikoproj/iam-manager/pull/104/files (and later realized that this change in progress) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kubernetes 1.22 deprecated the v1beta1 CRD API and replaced it with v1 CRD API. iam-manager's hack directory still uses the old API. Update that.
Note that this change is very specific about fixing the hack directory alone. There maybe more items that need the API upgrade. This change does not cover those.
Testing:
Before this change, using ./hack/install broke the iam-manager controller install. After this change, ./hack/install works fine.
Signed-off-by: Anusha Ragunathan anusha.ragu@gmail.com