Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spanish Translation minor changes #2729

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ChorizardAC
Copy link

Changes:

  • Period at the end of many descriptions.
  • Correction of many balance changes translations.

Suggestions:

  • Habilites should be linked like image below , because I realized that when you make balance changes, translations are not updated, because many of us dont know/read new changes and FINK doesnt indicate it when you use missing translation button.

Captura de pantalla 2025-01-21 185357

  • Many descriptions in ENGLISH doesnt have period at the end. It is a weird format. Many does, many doesnt.
  • "help_create_bot" english last sentence have 2 spaces i dont change it because it is not spanish.
  • bot_ready_submission double space first sentence.

@ChorizardAC
Copy link
Author

ChorizardAC commented Jan 22, 2025

  • From:
    image

  • to:
    image

Ok i think we are improving hehe

@sylvainpolletvillard
Copy link
Collaborator

The final punctuation point feels like nitpicking and is likely to cause conflicts, it would have been much easier to merge if you skipped that

@ChorizardAC
Copy link
Author

The final punctuation point feels like nitpicking and is likely to cause conflicts, it would have been much easier to merge if you skipped that

Working!

@ChorizardAC
Copy link
Author

ChorizardAC commented Jan 23, 2025

2 days ago when I uploaded this version, It didnt show any conflicts. But yesterday I saw many conflicts mark. Crazy.

A few moments ago I deleted 2 lines.
First one says >>>>>Spanish Translation minor changes and the last one >>>>>Master

Now it doesnt show any conflics. You think it is ok?

@sylvainpolletvillard
Copy link
Collaborator

I don't know how you managed to do it, but you completely duplicated the file content...

This is not going to work if you don't have basic knowledge of git and how to check the changes you push

@dan323
Copy link

dan323 commented Jan 25, 2025

It looks to me that you rebased and kept both verions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants