Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Counting Sort in JS #328

Closed
wants to merge 3 commits into from
Closed

Conversation

JMJ2312
Copy link
Contributor

@JMJ2312 JMJ2312 commented Oct 28, 2023

Added counting sort in Javascript with necessary comments and updated the ReadME file

Copy link
Owner

@kelvins kelvins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @JMJ2312, Heapsort.c was already included by PR #319. I don't know why Github is not showing a conflict but could you please remove it from this PR?

@JMJ2312
Copy link
Contributor Author

JMJ2312 commented Oct 31, 2023

Hi I have removed Heapsort.c

@kelvins
Copy link
Owner

kelvins commented Nov 13, 2023

Hi @JMJ2312, could you please update the branch? I believe the issue will be fixed.

@JMJ2312
Copy link
Contributor Author

JMJ2312 commented Nov 13, 2023

Hi, I have updated the branch

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this file was removed by mistake, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You had asked me to remove it in our conversation above right?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I wasn't so clear, sorry, I meant that Heapsort.c was included by PR 319, so we shouldn't have any reference to that file in this PR (since it's not related).

@kelvins
Copy link
Owner

kelvins commented Nov 25, 2023

Added by commit 5531625

@kelvins kelvins closed this Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants