Add multi-backend examples/generative/text_generation_with_miniature_gpt #1571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fchollet
reviewed
Nov 4, 2023
| # both `tensorflow` and `torch`. It does not work with JAX | ||
| # due to the behavior of `jax.numpy.tile` in a jit scope | ||
| # (used in `causal_attention_mask()`: `tile` in JAX does | ||
| # not support a dynamic `reps` argument. |
There was a problem hiding this comment.
I remember this issue. It's basically intractable apart from refactoring the example (I'm not sure the tile arg actually needs to be dynamic).
| @@ -326,236 +349,1261 @@ model.fit(text_ds, verbose=2, epochs=25, callbacks=[text_gen_callback]) | |||
| <div class="k-default-codeblock"> | |||
| ``` | |||
| Epoch 1/25 | |||
| 391/391 - 135s - loss: 5.5949 - dense_2_loss: 5.5949 | |||
|
|
|||
| WARNING: All log messages before absl::InitializeLog() is called are written to STDERR | |||
There was a problem hiding this comment.
I recommend hand-scrubbing all logs like this because they don't add value in the rendered page.
|
Update: the progress bar is fine. You should add |
mattdangerw
force-pushed
the
keras-3-text-generation-with-mini-gpt
branch
from
7a63697
to
f9aebfa
Compare
|
Done finally! Sorry for the delay. All ready again. |
mattdangerw
added
awaiting review
and removed
stat:awaiting response from contributor
labels
fchollet
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manually set this to tf because jax apparently does not work.
The log output is off (tons of repeated progress bars) compared to the original. Not sure if this is a Keras 3 bug?