-
Notifications
You must be signed in to change notification settings - Fork 19.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Fix backend/mlx/core
and backend/common/dtypes
for MLX + Improve integration_tests/numerical_test.py
#19619
Conversation
backend/mlx/nn.py:conv
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## mlx #19619 +/- ##
======================================
Coverage ? 69.12%
======================================
Files ? 506
Lines ? 45944
Branches ? 8499
======================================
Hits ? 31757
Misses ? 12534
Partials ? 1653
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…st and channels_last data formats
…lity and fix validation checks
…st and channels_last data formats
…keras_model function
…st and channels_last data formats
…t and channels_last data formats
…t and channels_last data formats v2
…t and channels_last data formats consistently
…stent formatting for Conv2D layers
…irst and channels_last data formats consistently
…nput_shape parameter in Conv2D layer
…put_shape parameter in Conv2D layer
…put_shape parameter from Conv2D layer
backend/mlx/nn.py:conv
backend/mlx/core
file and backend/common/dtypes
for MLX
backend/mlx/core
file and backend/common/dtypes
for MLXbackend/mlx/core
and backend/common/dtypes
for MLX
backend/mlx/core
and backend/common/dtypes
for MLXbackend/mlx/core
and backend/common/dtypes
for MLX + Improve integration_tests/numerical_test.py
backend/mlx/core
and backend/common/dtypes
for MLX + Improve integration_tests/numerical_test.py
backend/mlx/core
and backend/common/dtypes
for MLX + Improve integration_tests/numerical_test.py
if isinstance(x, mx.array): | ||
if x.dtype == mx.int64: | ||
x = x.astype(mx.int32) | ||
elif x.dtype == mx.float64: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is no mx.float64 ?
@@ -70,9 +70,11 @@ def convert_to_tensor(x, dtype=None, sparse=None): | |||
return x.value.astype(mlx_dtype) | |||
return x.value | |||
|
|||
if isinstance(x, np.ndarray): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we remove this cast, mlx crashes when running some test cases on my local machine. I logged a bug on mlx repo (see mlx backend issue).
It did not crash on CI tests on this pr because it is not being run on macOS ? Am really confused as I thought mlx runs only on macOS.
https://github.com/keras-team/keras/actions/runs/8907542811/job/24461598952#step:1:2
2024-05-01T09:07:10.5470064Z Current runner version: '2.316.0'
2024-05-01T09:07:10.5494922Z ##[group]Operating System
2024-05-01T09:07:10.5495654Z Ubuntu
2024-05-01T09:07:10.5496034Z 22.04.4
2024-05-01T09:07:10.5496669Z LTS
2024-05-01T09:07:10.5497089Z ##[endgroup]
2024-05-01T09:07:10.5497521Z ##[group]Runner Image
2024-05-01T09:07:10.5498174Z Image: ubuntu-22.04
2024-05-01T09:07:10.5498671Z Version: 20240422.1.0
2024-05-01T09:07:10.5499877Z Included Software: https://github.com/actions/runner-images/blob/ubuntu22/20240422.1/images/ubuntu/Ubuntu2204-Readme.md
2024-05-01T09:07:10.5501763Z Image Release: https://github.com/actions/runner-images/releases/tag/ubuntu22%2F20240422.1
backend/mlx/core
and backend/common/dtypes
for MLX + Improve integration_tests/numerical_test.py
backend/mlx/core
and backend/common/dtypes
for MLX + Improve integration_tests/numerical_test.py
I apologize for not being active here recently. I have been busy preparing for a very important job interview. My work with Keras has significantly improved my resume and contributed to my being selected for these interviews. so thank you! I promise I will return and be more active. |
Hi @Faisal-Alsrheed Any update on this PR? Please. Thank you! |
MLX Backend Specific Failures:
Missing Operations: The MLX backend lack implementations for specific operations, including: