-
Notifications
You must be signed in to change notification settings - Fork 19.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try to run tests with pytorch 2.3 #19859
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #19859 +/- ##
==========================================
- Coverage 78.95% 73.40% -5.55%
==========================================
Files 498 498
Lines 46129 46129
Branches 8487 8487
==========================================
- Hits 36419 33859 -2560
- Misses 8001 10619 +2618
+ Partials 1709 1651 -58
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sorry, there seemed to be one more place where things are pinned down. |
ps. it seemed from what I can test that the build for the first commit I made was:
|
wow this is unexpected, need to see what is different about the test environment.... |
Its installed from conda-forge, but the test fails seems to pass :/
|
You mean installing with pip fails but installing with conda works? I can reproduce the issue on MacOS (with the pip package) btw. |
I'm not too sure, i'll have to try to recreate my environment from scratch to confirm.
This is a good sign! |
I just can't recreate on linux....
I tried both with my nvidia drivers installed (550) and without. installation steps
pip list
|
Not sure what's going on with conda, but my hunch is that the bug with torch 2.3 + compile + keras is real, not a build issue. |
the How can i test that |
The test does that, there's nothing in your environment that it depends on. You can make sure that you're using the torch backend by setting the env variable |
Great thank you. now
correctly recreates the issue for me! Maybe an even simpler test that fails is :
|
Test for #19765