Add assert statement to check model structure on model_visualization_test #20208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #20208 +/- ##
=======================================
Coverage 79.36% 79.37%
=======================================
Files 501 501
Lines 47380 47435 +55
Branches 8706 8710 +4
=======================================
+ Hits 37604 37652 +48
- Misses 8015 8020 +5
- Partials 1761 1763 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fchollet
reviewed
Sep 4, 2024
| model = keras.Model(inputs, outputs) | ||
|
|
||
| edge_dict = get_edge_dict(model_to_dot(model)) | ||
|
|
||
| assert edge_dict["input_1 (InputLayer)"] == "dense_3 (Dense)" |
There was a problem hiding this comment.
Such statements should be made via self.assertEqual
There was a problem hiding this comment.
I updated the source code as your advice.
Additionally, I removed the main statement also, since, I think it can be replaced by just running ModelVisualizationTest class by pytest.
|
@fchollet Ok. After resoling this MR,I will look into that issue. Thanks. |
fchollet
approved these changes
Sep 5, 2024
google-ml-butler
bot
added
kokoro:force-run
ready to pull
google-ml-butler
bot
removed
ready to pull
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To verify the model's structure, I added a method that parses the model into a dictionary and included an assert statement to validate it.
Additionally, I assigned fixed names to each layer in the model to ensure consistency when referencing them.