Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade: react-native-reanimated 1 to 2x #45

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

NileshPatel17
Copy link

@NileshPatel17 NileshPatel17 commented Jan 8, 2022

@keremcubuk tested in android emulator and ios simulator, works fine.

Here is the Preview:

Untitled.mp4

@NileshPatel17 NileshPatel17 changed the title Upgrade: reanimated 1 to 2x Upgrade: react-native-reanimated 1 to 2x Jan 8, 2022
@keremcubuk
Copy link
Owner

Hi @NileshPatel17, thank you for your contribution but I have some questions in my mind. These are:

  • Should we add many custom changes for the template project?
  • Is it possible, can we solve without touching gradle files?
  • Should we use hermes? Because you need also add hermes-engine package for release build.

I will evaluate and research as soon as possible.

I want to learn your opinion about these questions.

Thank you for your support 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants