Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an end-date for KB8 to demonstrate how to create a PR for this … #618

Closed
wants to merge 1 commit into from

Conversation

sidcode
Copy link
Contributor

@sidcode sidcode commented Mar 7, 2024

…page.

Attention (CC)

Summary of changes

Description of the changes included in this pull request.
Steps to follow to confirm the feature is completed or the bug/issue is resolved.
Are there any dependencies?
Does this code break any existing functionality or introduce any risk?

Relevant Context

  • Feature: [ticket number](link to project management ticket)
  • Relevant Pull Request: #

How Has This Been Tested?

Screenshots (if appropriate):

Further comments


Types of changes

  • Content edit, File upload, content addition
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Technical Documentation Update
  • Other (please describe):

Does this introduce a breaking change?

Breaking change is defined as "A fix or feature that would cause existing functionality to change."

  • Yes
  • No

Checklist:

  • My code follows the code style of this project.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added/changed necessary documentation (if appropriate)
  • All new and existing tests passed.

@sidcode
Copy link
Contributor Author

sidcode commented Mar 7, 2024

Don't merge this PR. It has just been created to demonstrate how to create a PR.

@andytudhope
Copy link
Contributor

Closing in favour of #619

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants