Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes on the English and Chinese version of principled-people.mdx #631

Merged
merged 3 commits into from
May 3, 2024

Conversation

notthere-2023
Copy link
Contributor

Attention (CC)

Summary of changes

Correct a minor typo in English version of principled-people.mdx;
Create and update Chinese Translation for principled-people.mdx.
There aren't any dependencies.
This change didn't break functionality or introduce any risk.

Relevant Context

For now, no relevant context.

How Has This Been Tested?

It's language and character change, so no debugging and test has been done.
But I have checked the language again after the doc is created.

Screenshots (if appropriate):

image

Further comments

don't have further comments for now.


Types of changes

  • Content edit, File upload, content addition
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Technical Documentation Update
  • Other (please describe):

Does this introduce a breaking change?

Breaking change is defined as "A fix or feature that would cause existing functionality to change."

  • Yes
  • No

Checklist:

  • My code follows the code style of this project.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added/changed necessary documentation (if appropriate)
  • All new and existing tests passed.

@andytudhope
Copy link
Contributor

This is wonderful, thank you 🙏

In the background, I have been looking for someone to review this, but - if I can't find anyone in the next week - we can merge as is.

I really appreciate your work, thank you @notthere-2023 ❤️

@notthere-2023
Copy link
Contributor Author

It's my pleasure Andy, and it's great for me to learn and create with Kernel along the translation.

@andytudhope andytudhope merged commit b3b5402 into kernel-community:r2d May 3, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants