Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use_bridge: add option to create virtual bridge inside worker #128

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

venkata-pyla
Copy link

this option creates a virtual bridge inside a worker that
can be used to create isolated network between two or more
devices(qemu) running inside worker

Signed-off-by: venkata pyla venkata.pyla@toshiba-tsip.com

this option creates a virtual bridge inside a worker that
can be used to create isolated network between two or more
devices(qemu) running inside worker

Signed-off-by: venkata pyla <venkata.pyla@toshiba-tsip.com>
@patersonc
Copy link
Contributor

Hello @venkata-pyla

Thank you for the PR.

I suggest you also add an entry to the README.md to define use_bridge.

Chris

Signed-off-by: venkata pyla <venkata.pyla@toshiba-tsip.com>
@venkata-pyla
Copy link
Author

Hello @patersonc

Thank you for suggestion, i have updated the README file with usage of the option

@venkata-pyla
Copy link
Author

Hi,

I think i should give my motivation for sending this PR.

I am working on an open source project Civil Infrastructure Platform where I am utilizing the lava-docker infrastructure to execute tests that involve two devices to communicate each other with different protocols like ssh, chrony etc.

For that i created an isolated network with bridge inside the docker (workers) and which is used for my two qemu targets running as multi-node in lava.

The proposed changes creates the above infrastructure inside the worker only when this flag use_bridge is set in slaves section of the boards file.

I feel this solution may be useful who is using lava-docker and feel free to suggest or modify this PR to make it work better.

Thanks
Venkat

Copy link
Collaborator

@montjoie montjoie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure, it is usefull, basicly it is use_tap and the extra_actions could be in boards.yaml.
Probably I need to append a dockcomp_add_cap() to simplify your patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants