Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close #498 - Change the LogMessage parameter in the log(F[A]) method from NotIgnorable to MaybeIgnorable #499

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

kevin-lee
Copy link
Owner

Summary

Close #498 - Change the LogMessage parameter in the log(F[A]) method from NotIgnorable to MaybeIgnorable

@kevin-lee kevin-lee added this to the v2-m1 milestone Nov 7, 2023
@kevin-lee kevin-lee self-assigned this Nov 7, 2023
@github-actions github-actions bot added the pr label Nov 7, 2023
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #499 (2bd3d7e) into main (9736b8a) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #499      +/-   ##
==========================================
+ Coverage   97.61%   97.63%   +0.01%     
==========================================
  Files          15       15              
  Lines         168      169       +1     
  Branches        5        7       +2     
==========================================
+ Hits          164      165       +1     
  Misses          4        4              
Files Coverage Δ
...ore/shared/src/main/scala-2/loggerf/core/Log.scala 100.00% <100.00%> (ø)
...c/main/scala-2/loggerf/core/syntax/LogSyntax.scala 100.00% <ø> (ø)

@kevin-lee kevin-lee force-pushed the task/498/Ignorable-LogMessage-for-FA branch from f0a6ddf to 2bd3d7e Compare November 7, 2023 08:57
@kevin-lee kevin-lee merged commit 47a0ad1 into main Nov 7, 2023
13 checks passed
@kevin-lee kevin-lee deleted the task/498/Ignorable-LogMessage-for-FA branch November 7, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the LogMessage parameter in the log(F[A]) method from NotIgnorable to MaybeIgnorable
1 participant