Skip to content

Commit

Permalink
Only use the relative path in HTTP requests
Browse files Browse the repository at this point in the history
This causes a pretty big problem on out-of-spec HTTP servers (like
Flickr). Closes #31
  • Loading branch information
kevin1024 committed Sep 17, 2013
1 parent ce3d727 commit 912452e
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 3 deletions.
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -259,6 +259,8 @@ This library is a work in progress, so the API might change on you.
There are probably some [bugs](https://github.com/kevin1024/vcrpy/issues?labels=bug&page=1&state=open) floating around too.

##Changelog
* 0.3.1: Fix issue causing full paths to be sent on the HTTP request
line.
* 0.3.0: *Backwards incompatible release* - Added support for record
modes, and changed the default recording behavior to the "once" record
mode. Please see the documentation on record modes for more. Added
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ def run_tests(self):
sys.exit(errno)

setup(name='vcrpy',
version='0.3.0',
version='0.3.1',
description="A Python port of Ruby's VCR to make mocking HTTP easier",
author='Kevin McCarthy',
author_email='me@kevinmccarthy.org',
Expand Down
6 changes: 6 additions & 0 deletions tests/integration/test_wild.py
Original file line number Diff line number Diff line change
Expand Up @@ -45,3 +45,9 @@ def _pretend_to_be_flickr_library():
assert len(cass) == 1
_pretend_to_be_flickr_library()
assert cass.play_count == 1

def test_flickr_should_respond_with_200(tmpdir):
testfile = str(tmpdir.join('flickr.yml'))
with vcr.use_cassette(testfile):
r = requests.post("http://api.flickr.com/services/upload")
assert r.status_code == 200
4 changes: 2 additions & 2 deletions vcr/stubs/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ def send(self, data):

def _send_request(self, method, url, body, headers):
"""
Coppy+pasted from python stdlib 2.6 source because it
Copy+pasted from python stdlib 2.6 source because it
has a call to self.send() which I have overridden
#stdlibproblems #fml
"""
Expand Down Expand Up @@ -160,7 +160,7 @@ def getresponse(self, _=False):
self._baseclass.request(
self,
method=self._vcr_request.method,
url=self._vcr_request.url,
url=self._vcr_request.path,
body=self._vcr_request.body,
headers=dict(self._vcr_request.headers or {})
)
Expand Down

0 comments on commit 912452e

Please sign in to comment.