Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix httpx upload #657

Closed
wants to merge 1 commit into from
Closed

Fix httpx upload #657

wants to merge 1 commit into from

Conversation

07pepa
Copy link

@07pepa 07pepa commented Sep 24, 2022

Fix httpx upload
c2e3be0 
- removed unneeded decoding of body in httpx_stubs.py
- added asset to upload
- added equivalent cassette for upload
- added testing to cover uploading to vcr with httpx
@07pepa 07pepa mentioned this pull request Sep 24, 2022
Open
@07pepa 07pepa mentioned this pull request Oct 11, 2022
Merged
@kevin1024 kevin1024 force-pushed the master branch 3 times, most recently from df3997c to 34d5384 Compare June 26, 2023 17:54
@parkerhancock
Copy link
Contributor

Fixed in #784

@parkerhancock
Copy link
Contributor

I suggest we close this one in view of #784

@07pepa 07pepa closed this by deleting the head repository Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] HTTPX Binary upload data unsuported
2 participants
@07pepa @parkerhancock