Fix an issue with aiohttp, related posting json #768
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
There is an issue with aiohttp, when a developer sends a json kwarg it is overwritten by the data kwarg. In aiohttp the data kwarg is set to None by default and VCR will always default to
None
.Resolution
We should change the kwargs check to check for the json key first and fall back to data. Because data is defaulted and will always exist. But json doesn't always exist.
fixes: #762