Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI / Block urllib3 >=2 for PyPy (alternative to #786) #787

Merged
merged 1 commit into from
Dec 10, 2023

Conversation

hartwork
Copy link
Collaborator

@hartwork hartwork commented Dec 8, 2023

In reaction to #775 (comment)
Alternative to #786

@hartwork hartwork changed the title setup.py: Block urllib3 >=2 for PyPy (including 3.10; CI kept failing) setup.py: Block urllib3 >=2 for PyPy (including 3.10; CI kept failing; alternative to #786) Dec 8, 2023
@hartwork hartwork changed the title setup.py: Block urllib3 >=2 for PyPy (including 3.10; CI kept failing; alternative to #786) setup.py: Block urllib3 >=2 for PyPy (CI kept failing; alternative to #786) Dec 8, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c062c9f) 90.10% compared to head (0e57182) 90.10%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #787   +/-   ##
=======================================
  Coverage   90.10%   90.10%           
=======================================
  Files          27       27           
  Lines        1809     1809           
  Branches      335      335           
=======================================
  Hits         1630     1630           
  Misses        134      134           
  Partials       45       45           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hartwork hartwork changed the title setup.py: Block urllib3 >=2 for PyPy (CI kept failing; alternative to #786) Block urllib3 >=2 for PyPy (CI kept failing; alternative to #786) Dec 8, 2023
@hartwork hartwork changed the title Block urllib3 >=2 for PyPy (CI kept failing; alternative to #786) Fix CI / Block urllib3 >=2 for PyPy (CI kept failing; alternative to #786) Dec 9, 2023
@hartwork hartwork changed the title Fix CI / Block urllib3 >=2 for PyPy (CI kept failing; alternative to #786) Fix CI / Block urllib3 >=2 for PyPy (alternative to #786) Dec 9, 2023
@hartwork hartwork merged commit 604c0be into master Dec 10, 2023
9 checks passed
@hartwork hartwork deleted the fix-pypy-3-10 branch December 10, 2023 22:32
@josumoreno-BP
Copy link

josumoreno-BP commented Feb 20, 2024

@hartwork don't you think that python_version <'3.10' should also be added to the line with platform_python_implementation =='PyPy'? (or directly remove this line because it is already covered by the previous marker)

On our personal use case, we use poetry and it adds to the lock file the dependencies to make it compatible with all the possible destination platforms. We use python 3.11 and this line is added to the lock, blocking us using a urllib3>=2. You can read context here

@hartwork
Copy link
Collaborator Author

@josumoreno-BP this is not the right place for a bug report and after re-checking the change in here, it still seems correct. I'm not sure I understand the poetry part. if this matter it will need a dedicated bug report and more elaboration, at least with me. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants