-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI / Block urllib3 >=2 for PyPy (alternative to #786) #787
Conversation
It kept failing CI
setup.py
: Block urllib3 >=2 for PyPy (including 3.10; CI kept failing)setup.py
: Block urllib3 >=2 for PyPy (including 3.10; CI kept failing; alternative to #786)
setup.py
: Block urllib3 >=2 for PyPy (including 3.10; CI kept failing; alternative to #786)setup.py
: Block urllib3 >=2 for PyPy (CI kept failing; alternative to #786)
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #787 +/- ##
=======================================
Coverage 90.10% 90.10%
=======================================
Files 27 27
Lines 1809 1809
Branches 335 335
=======================================
Hits 1630 1630
Misses 134 134
Partials 45 45 ☔ View full report in Codecov by Sentry. |
setup.py
: Block urllib3 >=2 for PyPy (CI kept failing; alternative to #786)
@hartwork don't you think that On our personal use case, we use poetry and it adds to the lock file the dependencies to make it compatible with all the possible destination platforms. We use python 3.11 and this line is added to the lock, blocking us using a urllib3>=2. You can read context here |
@josumoreno-BP this is not the right place for a bug report and after re-checking the change in here, it still seems correct. I'm not sure I understand the poetry part. if this matter it will need a dedicated bug report and more elaboration, at least with me. Thanks. |
In reaction to #775 (comment)
Alternative to #786