Start using pre-commit in CI #800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hartwork
force-pushed
the
pre-commit-ci
branch
from
d40177f
to
fc51e1f
Compare
hartwork
force-pushed
the
pre-commit-ci
branch
from
fc51e1f
to
ecc45b1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #800 +/- ##
=======================================
Coverage 90.13% 90.13%
=======================================
Files 27 27
Lines 1815 1815
Branches 336 336
=======================================
Hits 1636 1636
Misses 134 134
Partials 45 45 ☔ View full report in Codecov by Sentry. |
|
@jairhenrique cool! Let me revert the error-trigger commit and see if CI gets all green… |
hartwork
force-pushed
the
pre-commit-ci
branch
from
ecc45b1
to
b0cb876
Compare
|
@jairhenrique cool! Merging… |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jairhenrique I have added one deliberate formatting error to showcase how this integration will present formatting errors in practice. Looking forward to your review 🍻
PS: Review on commit level is advised 😃