Fix httpx async / decoded responses #825
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up from #807.
I tested v6.0.1 last week and my issue recording requests against openai was resolved. However, I just uplifted my app from Flask to FastAPI for async support and ran into an issue with v6.0.1 trying to start another event loop:
I also found
assert not hasattr(resp, "_decoder")
was preventing recordinghttps://api.openai.com/v1/embeddings
responses made by the openai client as they seem to already be decoded by the client before this code runs.The changes in this PR resolve both issues and allow me to record openai responses in my uplifted FastAPI async app. It's not clear to me the benefit of the async refactor in
httpx_stubs.py
, but I'll note that my original patch in #807 continued to work in my uplifted FastAPI app.