fix: use poetry, not old setuptools #859
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we should stick to setuptools for now. I'd merge a PR that switched to pyproject.toml based setuptools |
|
@graingert is that what #767 provides, or did you have something else in mind? |
|
I'll close today. Not interested in explicit dependency on setuptools |
Comment on lines
+31
to
+39
| python = ">=3.8" | ||
| pyyaml = "^6.0.1" | ||
| wrapt = "^1.16.0" | ||
| yarl = "^1.9.4" | ||
| urllib3 = [ | ||
| { version = "<2", markers = "python_version < '3.10'" }, | ||
| { version = "<2", markers = "platform_python_implementation == 'PyPy'" }, | ||
| { version = ">=2.2.2", markers = "python_version >= '3.10' and platform_python_implementation != 'PyPy'" } | ||
| ] |
There was a problem hiding this comment.
after thought. This is incorrect. This package has no dependencies as it is, itself a dev dependency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aims to solve the setuptools problem of #858 #856 and #855 but by using a more modern tool
poetry buildshould, AFAIK build a universal wheel for you.https://github.com/LewisCowlesMotive/vcrpy/releases/tag/v6.0.2 has notes on testing this fix.
I don't know how your CI works, so there may yet be more adjustments there.