Allow serializing txn without verification of signatures #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Saw some odd results in tests, need to check if processTransaction checks the signatures on the server side. If it doesn't, this feature would be a footgun best avoided |
|
Closing because it is indeed a footgun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought a bit about this problem and I think #12 is the most straightforward way to solve it. It feels inelegant to specify serialization config when we're sending a transaction, but the design differences between web3.js Transaction and solana-sdk Transaction mean we kinda have to serialize the tx, so that's the root of the inelegance. We could switch to not verifying the txn signatures but that would also be surprising behaviour for people.
Making a new PR to fix unrelated GH actions problems and any other issue that arises