Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sequential search with upper bound param #335

Merged
merged 2 commits into from
Jun 11, 2024
Merged

sequential search with upper bound param #335

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc137a7
sequential search with upper bound param
friendlymatthew Jun 11, 2024
912ed63
remove additional test
friendlymatthew Jun 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions pkg/hnsw/hnsw_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -476,6 +476,7 @@ func TestHnsw_InsertVector(t *testing.T) {
}
}
})

}

func TestHnsw_KnnSearch(t *testing.T) {
Expand Down Expand Up @@ -598,4 +599,37 @@ func TestHnsw_KnnSearch(t *testing.T) {
t.Fatalf("expected closest points to be %v, got %v", expected, got)
}
})

t.Run("sequential search with upper bound params", func(t *testing.T) {
h := NewHnsw(2, 12, 12, Point{0, 0})
for i := 1; i <= 8; i++ {
if err := h.InsertVector(Point{float32(i), float32(i + 1)}); err != nil {
t.Fatalf("failed to insert point: %v, err: %v", Point{float32(i), float32(i + 1)}, err)
}
}

found, err := h.KnnSearch(Point{float32(0), float32(0)}, 10)

if err != nil {
t.Fatalf("failed to find closest neighbors: %v", err)
}

if found.Len() != 9 {
t.Fatalf("expected to find 9 closest neighbors, got %v", found.Len())
}

expectedId := Id(0)

for found.IsEmpty() {
nnItem, err := found.PopItem()
if err != nil {
t.Fatalf("failed to pop item: %v, err: %v", found, err)
}
if expectedId != nnItem.id {
t.Fatalf("expected to find %v, got %v", expectedId, nnItem.id)
}

expectedId += 1
}
})
}
Loading