Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

indexfile tsreader #97

Merged
merged 6 commits into from
Feb 13, 2024
Merged

indexfile tsreader #97

merged 6 commits into from
Feb 13, 2024

Conversation

friendlymatthew
Copy link
Collaborator

Extremely rough draft

friendlymatthew
friendlymatthew commented Feb 9, 2024
View reviewed changes
src/index-file.ts Outdated Show resolved Hide resolved
friendlymatthew
friendlymatthew commented Feb 9, 2024
View reviewed changes
src/index-file.ts Outdated Show resolved Hide resolved
friendlymatthew
friendlymatthew commented Feb 9, 2024
View reviewed changes
src/btree/multi.ts Outdated Show resolved Hide resolved
friendlymatthew
friendlymatthew commented Feb 9, 2024
View reviewed changes
src/btree/pagefile.ts Outdated Show resolved Hide resolved
kevmo314
kevmo314 approved these changes Feb 9, 2024
View reviewed changes
Copy link
Owner

@kevmo314 kevmo314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good, definitely in the right direction. Some optimization comments but otherwise it should work and the design looks fine.

src/btree/multi.ts Outdated Show resolved Hide resolved
src/btree/multi.ts Outdated Show resolved Hide resolved
src/btree/multi.ts Outdated Show resolved Hide resolved
src/btree/multi.ts Show resolved Hide resolved
src/btree/pagefile.ts Outdated Show resolved Hide resolved
friendlymatthew
friendlymatthew commented Feb 12, 2024
View reviewed changes
src/btree/multi.ts Outdated Show resolved Hide resolved
@friendlymatthew friendlymatthew marked this pull request as ready for review February 13, 2024 15:34
@friendlymatthew friendlymatthew merged commit b1b97d7 into main Feb 13, 2024
5 checks passed
@friendlymatthew friendlymatthew deleted the indexfile-tsreader branch February 15, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevmo314 kevmo314 kevmo314 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@friendlymatthew @kevmo314