-
Notifications
You must be signed in to change notification settings - Fork 618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pr_fixup action #1339
Merged
Merged
Add pr_fixup action #1339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garritfra
force-pushed
the
feature/yaml-formatter
branch
from
November 7, 2023 09:23
f832e44
to
5054ae1
Compare
garritfra
force-pushed
the
feature/yaml-formatter
branch
from
November 7, 2023 09:42
51c7cc7
to
d0c3c15
Compare
garritfra
force-pushed
the
feature/yaml-formatter
branch
from
November 7, 2023 09:48
8221bb0
to
1222cb7
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an action that
a) sorts the entries alphabetically
b) adds back the newline delimiter in the array
c) formats the document
d) commits the changes if applicable
An example automated commit can be found here: 2a3d10d
This removes the need to check for accidentally committed whitespace, which is a bit hard to spot in the GitHub mobile app. Furthermore, we don't need the extra check for alphabetical order.