Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deleted: tests/unit-fail-compilation/kcc_config #473

Closed
wants to merge 2 commits into from

Conversation

charala1
Copy link
Contributor

No description provided.

@charala1 charala1 requested a review from dwightguth June 17, 2019 17:05
@dwightguth
Copy link
Member

can we put files with this name in .gitignore too?

@charala1
Copy link
Contributor Author

charala1 commented Jun 17, 2019 via email

@chathhorn
Copy link
Member

This was added to prevent differences in error messages depending on whether that file was produced or not. It might not be needed anymore because I think we're chopping that line now anyway, but please verify locally -- these tests are run on rv-match, not in the c-sem pr job.

@charala1
Copy link
Contributor Author

This was added to prevent differences in error messages depending on whether that file was produced or not. It might not be needed anymore because I think we're chopping that line now anyway, but please verify locally -- these tests are run on rv-match, not in the c-sem pr job.

@chathhorn what should I verify then? That the file is not produced, or something else?

@charala1
Copy link
Contributor Author

Closing in favor of issue #492

@charala1 charala1 closed this Jun 21, 2019
@charala1 charala1 deleted the minas-rm-kcc_config branch June 28, 2019 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants