-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix trt assign #215
Fix trt assign #215
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep totally fine to open another PR for the same thing! Looks fine to me. Though this leaves trtObserve
to produce 0/1 for singular formulas and 1...n for n formulas but I guess that makes sense withing the context of that function and is also mentioned in the docs:
@return An integer (group) ranging from 1 to length of the probability vector
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 8144616 is merged into main:
|
Co-authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 73de6bc is merged into main:
|
@assignUser I created this new pull request. Not sure this is proper workflow, but it is what it is. Check it out. It seems to do the trick.