Fixing Prompt Parser #85
Conversation
Prompt parser will get tripped up if "--" is found anywhere in the prompt and isn't surrounded by specific deliminators. Instead let's force arguments to be at the beginning of the prompt and collect no more arguments after. This way users don't have to place flags inside deliminators and we extend what we can pass to the LLMs. More context is discussed in kharvd#52 with an example.
|
Was the problem here the testing? Looks like it failed on building the depends, which I did not modify. I also did not introduce any new packages or imports. Fwiw, I've been using this version for a month now. |
|
For now you can pull from my branch since @kharvd has only updated pricing and versioning. But yeah, I'm a bit confused why this isn't being merged either. The build error is on the dependency install (a timeout on one of the packages), so nothing to do with what I touched. @kharvd can we trigger a rebuild? I didn't check your actions to see what will cause this but I can make a trivial change if that's needed. |
|
@stevenwalton Yup, just saw the stale issue :) |
|
I just synced the branches. If I run into any issues I'll fix or if you find any let me know |
|
I would also value this being merged. Many thanks for an excellent plugin. |
|
If you are fixing a bug, please add a test case that fails without your fix - and fix the existing tests that are failing. |
- Do not update sub-sub version - Spelling - Add test cases and remove old test cases
|
Done. Would you like me to update the README? Fwiw, someone could make this a bit better if there is a need to have an option that takes in several words as |
|
I would also value this being merged! |
|
For those that keep asking for the merge, in the mean time you can directly pull to my branch. I'll try to keep it in sync but ping me here or there if I have missed this. Idk if @kharvd has abandoned the project but I'll take PRs into mine. |
|
sorry for the delay here. I'm inclined to remove inline flags functionality altogether rather than force them to appear at the beginning of the prompt. this has obviously been causing more issues than i'd prefer, and personally i just stopped using these flags altogether. |
|
Sure, I can understand that. But as of right now, if anyone uses I get that things take time, but then treat this as a patch. It's not a true "fix" because you're going to later throw it out, but my merging at least people won't be crashing while that's figured out. Truthfully, I don't use those flags either. But I did this because I was annoyed at how often I crashed anytime I'd try to submit requests that involved bash lol |
Prompt parser will get tripped up if "--" is found anywhere in the prompt and isn't surrounded by specific deliminators. Instead let's force arguments to be at the beginning of the prompt and collect no more arguments after. This way users don't have to place flags inside deliminators and we extend what we can pass to the LLMs.
More context is discussed in #52 with an example.