Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove default features from ed25519-dalek #16

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

dj8yfo
Copy link
Contributor

@dj8yfo dj8yfo commented Jun 24, 2024

go from

ed25519-dalek v2.1.1
├── ed25519-dalek feature "alloc"
│   └── ed25519-dalek feature "std"
│       └── ed25519-dalek feature "default"
│           ├── near-ledger v0.7.0 
│           │   └── near-ledger feature "default" 
│           └── slipped10 v0.4.5
│               └── slipped10 feature "default"
│                   └── near-ledger v0.7.0 
├── ed25519-dalek feature "default" 
├── ed25519-dalek feature "fast"
│   └── ed25519-dalek feature "default" 
├── ed25519-dalek feature "hazmat"
│   └── near-crypto v0.23.0
│       └── near-crypto feature "default"
│           └── near-primitives v0.23.0
│               └── near-primitives feature "default"
│                   └── near-ledger v0.7.0 
│                   [dev-dependencies]
│                   └── near-ledger v0.7.0 
│           [dev-dependencies]
│           └── near-ledger v0.7.0 
├── ed25519-dalek feature "rand_core"
│   └── near-crypto v0.23.0 
├── ed25519-dalek feature "std" 
└── ed25519-dalek feature "zeroize"
    ├── ed25519-dalek feature "alloc" 
    └── ed25519-dalek feature "default" 

to

ed25519-dalek v2.1.1
├── near-ledger v0.7.0 
│   └── near-ledger feature "default" 
└── slipped10 v0.4.6 
    └── slipped10 feature "default"
        └── near-ledger v0.7.0 
├── ed25519-dalek feature "hazmat"
│   └── near-crypto v0.23.0
│       └── near-crypto feature "default"
│           └── near-primitives v0.23.0
│               └── near-primitives feature "default"
│                   └── near-ledger v0.7.0 
│                   [dev-dependencies]
│                   └── near-ledger v0.7.0 
│           [dev-dependencies]
│           └── near-ledger v0.7.0 
└── ed25519-dalek feature "rand_core"
    └── near-crypto v0.23.0 (*)

@dj8yfo dj8yfo marked this pull request as ready for review June 24, 2024 14:56
@dj8yfo
Copy link
Contributor Author

dj8yfo commented Jun 24, 2024

@khorolets please take a look when you have a spare moment

@frol frol merged commit 2cd291c into khorolets:main Jun 24, 2024
1 check passed
@khorolets khorolets mentioned this pull request Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants