feat!: sign_message_nep413, sign_message_nep366_delegate_action features, examples
#6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khorolets
reviewed
Jan 18, 2024
| @@ -16,14 +16,17 @@ const INS_GET_VERSION: u8 = 6; // Instruction code to get app version from the L | |||
| const INS_SIGN_TRANSACTION: u8 = 2; // Instruction code to sign a transaction on the Ledger | |||
| const NETWORK_ID: u8 = 'W' as u8; // Instruction parameter 2 | |||
| const RETURN_CODE_OK: u16 = 36864; // APDUAnswer.retcode which means success from Ledger | |||
| const CHUNK_SIZE: usize = 128; // Chunk size to be sent to Ledger | |||
| const CHUNK_SIZE: usize = 250; // Chunk size to be sent to Ledger | |||
There was a problem hiding this comment.
I don't recall was the size of this chunk 128 because of historical reason or due to the capabilities of the Nano S. Can you confirm Nano S works with this increased?
There was a problem hiding this comment.
yes. this is specifically to handle large txs. see Case 2 in app-near-rs/tree/proto/README
There was a problem hiding this comment.
additionally reconfirmed that this chunk size is fine with app-near 1.2.1 for nanos, downloaded from Ledger Live
added 11 commits
January 25, 2024 21:00
dj8yfo
force-pushed
the
more_examples
branch
2 times, most recently
from
ece8b02
to
96d5eb2
Compare
dj8yfo
force-pushed
the
more_examples
branch
2 times, most recently
from
b281207
to
16c8b62
Compare
dj8yfo
force-pushed
the
more_examples
branch
3 times, most recently
from
8cd803d
to
72fde37
Compare
dj8yfo
changed the title
sign_message_nep413, sign_message_nep366_delegate_action features, examples
dj8yfo
changed the title
sign_message_nep413, sign_message_nep366_delegate_action features, examplessign_message_nep413, sign_message_nep366_delegate_action features, examples
frol
approved these changes
Feb 27, 2024
There was a problem hiding this comment.
Looks good to me.
@khorolets please, review, merge, and cut a new release 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
blind_sign_transactionpubilc api was removedthis pr is fast-forward extension of #5