Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker compose + server Dockerfile and update Docker Flow #5

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mroxso
Copy link

@mroxso mroxso commented Oct 18, 2024

This pull request includes changes to Docker configurations and build scripts to standardize the environment setup for the kibo project. The most important changes include renaming and modifying the Dockerfile.parser, adding a new Dockerfile.server, updating the compose.yaml file to include new services, and modifying the build script to use the new Dockerfiles.

Dockerfile changes:

  • Dockerfile.parser: Renamed from docker/Dockerfile, changed the working directory to /kibo/, and updated the command to run the parser with the correct manifest path.
  • Dockerfile.server: Added a new Dockerfile for the server, setting up environment variables and the working directory, and copying the necessary files.

Compose file changes:

  • compose.yaml: Added services for kibo-parser and kibo-server, specifying build contexts, Dockerfiles, and volume mappings.

Build script changes:

  • docker/build.sh: Updated the build script to use the new Dockerfiles for kibo-parser and kibo-server, and commented out the git clone commands.

@mroxso mroxso mentioned this pull request Oct 18, 2024
@mroxso
Copy link
Author

mroxso commented Oct 18, 2024

I did not really check for volumes to work and what env variables are needed or what ports to expose.
This may be still work-in-progress.
Also the rust application should build when building the docker image. Right now it is only copying everything and it is building on runtime which is not best practice.

@nym21
Copy link
Member

nym21 commented Oct 18, 2024

Thanks a lot ! I'll add some comments if needed
And yes I saw about that best practice but meant to do it at the very end when everything else was working

@nym21
Copy link
Member

nym21 commented Oct 18, 2024

If you prefer for me to do the changes please let me know, don't mean to burden you with this. I'm just asking for help as I'm really not familiar with Docker, I'll spend 10X more time and frustration than someone who's used to it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants