Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.67.x-blue] Fix ActionFieldValue clone (#5991) #65

Merged

Conversation

yesamer
Copy link
Member

@yesamer yesamer commented Jul 10, 2024

Backport of apache#5991 in kiegroup repo

  • [private-bamoe-issues#2091] Fix ActionFieldValue clone

  • Fix template test

  • [private-bamoe-issues#2091] Fix ActionFieldValue clone

* [private-bamoe-issues#2091] Fix ActionFieldValue clone

* Fix template test

* [private-bamoe-issues#2091] Fix ActionFieldValue clone

---------

Co-authored-by: Gabriele-Cardosi <gabriele.cardosi@ibm.com>
Co-authored-by: rikkola <toni@rikkola.net>
@yesamer
Copy link
Member Author

yesamer commented Jul 10, 2024

Jenkins run fdb

Copy link

@gitgabrio gitgabrio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx @yesamer

@yesamer
Copy link
Member Author

yesamer commented Jul 10, 2024

Jenkins run cdb

@yesamer
Copy link
Member Author

yesamer commented Jul 10, 2024

Jenkins retest this

@yesamer
Copy link
Member Author

yesamer commented Jul 10, 2024

Jenkins retest this

@yesamer
Copy link
Member Author

yesamer commented Jul 10, 2024

Jenkins run cdb

@yesamer yesamer added the backport-7.67.x-blue Generate backport PR for 7.67.x-blue branch label Jul 10, 2024
@yesamer
Copy link
Member Author

yesamer commented Jul 10, 2024

Jenkins retest this

1 similar comment
@yesamer
Copy link
Member Author

yesamer commented Jul 10, 2024

Jenkins retest this

@yesamer
Copy link
Member Author

yesamer commented Jul 10, 2024

Jenkins run cdb

@yesamer
Copy link
Member Author

yesamer commented Jul 10, 2024

Jenkins run fdb

@yesamer
Copy link
Member Author

yesamer commented Jul 10, 2024

Jenkins retest this

@yesamer
Copy link
Member Author

yesamer commented Jul 10, 2024

Jenkins run cdb

@yesamer
Copy link
Member Author

yesamer commented Jul 10, 2024

Jenkins retest this

@yesamer
Copy link
Member Author

yesamer commented Jul 11, 2024

Jenkins run fdb

@yesamer
Copy link
Member Author

yesamer commented Jul 11, 2024

Jenkins retest this

2 similar comments
@yesamer
Copy link
Member Author

yesamer commented Jul 11, 2024

Jenkins retest this

@yesamer
Copy link
Member Author

yesamer commented Jul 11, 2024

Jenkins retest this

@yesamer
Copy link
Member Author

yesamer commented Jul 11, 2024

@mareknovotny I did my best to be a good citizen here, but I have the impression those PR builds will never be green. Do you mind taking a look, please?

//cc @porcelli

@yesamer
Copy link
Member Author

yesamer commented Jul 11, 2024

Jenkins run fdb

3 similar comments
@yesamer
Copy link
Member Author

yesamer commented Jul 12, 2024

Jenkins run fdb

@yesamer
Copy link
Member Author

yesamer commented Jul 12, 2024

Jenkins run fdb

@yesamer
Copy link
Member Author

yesamer commented Jul 15, 2024

Jenkins run fdb

@mareknovotny
Copy link
Member

@yesamer well, if you check the Jenkins build log it shows you that error is in the followed sonar analysis

[2024-07-11T07:38:59.738Z] [ERROR] Failed to execute goal org.sonarsource.scanner.maven:sonar-maven-plugin:3.6.0.1398:sonar (default) on project drools-retediagram: Could not find the pullrequest with key '65': Error 404 on https://sonarcloud.io/api/alm_integration/show_pullrequest?project=org.drools%3Adrools&pullrequestKey=65 : {"errors":[{"msg":"The pullrequest could not be found"}]} -> [Help 1]

it was already reported this branch has problems with configured sonarcloud.io projects.

@gitgabrio
Copy link

@mareknovotny OOC: where is that maven plugin should get the projectKey to be used in the rest invocation ?
IIUC, the endpoint should be
https://sonarcloud.io/api/alm_integration/show_pullrequest?project=kiegroup_drools&pullrequestKey=65

@yesamer
Copy link
Member Author

yesamer commented Jul 15, 2024

Jenkins run fdb

2 similar comments
@yesamer
Copy link
Member Author

yesamer commented Jul 15, 2024

Jenkins run fdb

@yesamer
Copy link
Member Author

yesamer commented Jul 16, 2024

Jenkins run fdb

@mareknovotny
Copy link
Member

@mareknovotny OOC: where is that maven plugin should get the projectKey to be used in the rest invocation ? IIUC, the endpoint should be https://sonarcloud.io/api/alm_integration/show_pullrequest?project=kiegroup_drools&pullrequestKey=65

there is no property right now as using the default, but you can set it up for this case if required see https://stackoverflow.com/questions/23312738/override-sonar-projectkey-when-using-maven

@gitgabrio
Copy link

Jenkins retest this

@yesamer
Copy link
Member Author

yesamer commented Jul 16, 2024

Jenkins run fdb

2 similar comments
@akumar074
Copy link
Member

Jenkins run fdb

@yesamer
Copy link
Member Author

yesamer commented Jul 17, 2024

Jenkins run fdb

@yesamer yesamer merged commit 4d48a98 into kiegroup:7.67.x-blue Jul 17, 2024
7 checks passed
@yesamer yesamer deleted the 7.67.x-blue-fix-actionfieldclone branch July 17, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-7.67.x-blue Generate backport PR for 7.67.x-blue branch
Projects
None yet
5 participants