Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.67.x-blue] Improve Import Resolver error messages to be more user friendly (#6014) #66

Merged

Conversation

yesamer
Copy link
Member

@yesamer yesamer commented Jul 10, 2024

Backport of apache#6014

  • Improved Error Messages + Logs

  • dependabot.yml fixed

  • dependabot.yml fixed

  • Change Request

  • Minor change

  • Tests fixed

(cherry picked from commit ddb72c6)

Thank you for submitting this pull request

NOTE!: kiegroup/drools is maintained only for old branches e.g. 7.x, 7.67.x, 7.67.x-blue.
If you are submitting a PR for main branch, please use apache/incubator-kie-drools instead.

Ports If a forward-port or a backport is needed, paste the forward port PR here

link

JIRA: (please edit the JIRA link if it exists)

link

referenced Pull Requests: (please edit the URLs of referenced pullrequests if they exist)

  • paste the link(s) from GitHub here
  • link 2
  • link 3 etc.
How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:
  • for pull request checks
    Please add comment: Jenkins retest this

  • for a specific pull request check
    Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] tests

  • for a full downstream build

    • for jenkins job: please add comment: Jenkins run fdb
    • for github actions job: add the label run_fdb
  • a compile downstream build please add comment: Jenkins run cdb

  • a full production downstream build please add comment: Jenkins execute product fdb

  • an upstream build please add comment: Jenkins run upstream

  • for quarkus branch checks
    Run checks against Quarkus current used branch
    Please add comment: Jenkins run quarkus-branch

  • for a quarkus branch specific check
    Run checks against Quarkus current used branch
    Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] quarkus-branch

  • for quarkus main checks
    Run checks against Quarkus main branch
    Please add comment: Jenkins run quarkus-main

  • for a specific quarkus main check
    Run checks against Quarkus main branch
    Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] quarkus-main

  • for quarkus lts checks
    Run checks against Quarkus lts branch
    Please add comment: Jenkins run quarkus-lts

  • for a specific quarkus lts check
    Run checks against Quarkus lts branch
    Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] quarkus-lts

  • for native checks
    Run native checks
    Please add comment: Jenkins run native

  • for a specific native check
    Run native checks
    Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] native

  • for native lts checks
    Run native checks against quarkus lts branch
    Please add comment: Jenkins run native-lts

  • for a specific native lts check
    Run native checks against quarkus lts branch
    Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] native-lts

How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

… be more user friendly (apache#6014)

* Improved Error Messages + Logs

* dependabot.yml fixed

* dependabot.yml fixed

* Change Request

* Minor change

* Tests fixed

(cherry picked from commit ddb72c6)
@yesamer yesamer added the backport-7.67.x-blue Generate backport PR for 7.67.x-blue branch label Jul 10, 2024
@yesamer
Copy link
Member Author

yesamer commented Jul 10, 2024

Jenkins run fdb

@yesamer
Copy link
Member Author

yesamer commented Jul 10, 2024

Jenkins run cdb

@yesamer
Copy link
Member Author

yesamer commented Jul 10, 2024

Jenkins retest this

3 similar comments
@yesamer
Copy link
Member Author

yesamer commented Jul 10, 2024

Jenkins retest this

@yesamer
Copy link
Member Author

yesamer commented Jul 10, 2024

Jenkins retest this

@yesamer
Copy link
Member Author

yesamer commented Jul 11, 2024

Jenkins retest this

@yesamer
Copy link
Member Author

yesamer commented Jul 11, 2024

Jenkins run fdb

@yesamer
Copy link
Member Author

yesamer commented Jul 11, 2024

Jenkins retest this

1 similar comment
@yesamer
Copy link
Member Author

yesamer commented Jul 11, 2024

Jenkins retest this

@yesamer
Copy link
Member Author

yesamer commented Jul 11, 2024

Jenkins retest this

@yesamer
Copy link
Member Author

yesamer commented Jul 11, 2024

Jenkins run fdb

1 similar comment
@yesamer
Copy link
Member Author

yesamer commented Jul 12, 2024

Jenkins run fdb

@yesamer
Copy link
Member Author

yesamer commented Jul 12, 2024

Jenkins run fdb

@yesamer
Copy link
Member Author

yesamer commented Jul 12, 2024

Jenkins run fdb

1 similar comment
@yesamer
Copy link
Member Author

yesamer commented Jul 15, 2024

Jenkins run fdb

@yesamer
Copy link
Member Author

yesamer commented Jul 15, 2024

Jenkins run cdb

@mareknovotny
Copy link
Member

Jenkins retest this please

@mareknovotny
Copy link
Member

i tried to rebind the repository on sonarcloud.io to check if that will remove the previous error with linked kiegroup/drools-archive repository.
If not and there will be that jdk11 vs jdk17 error in sonar analysis, i will need to remove that mvn command with sonar-analysis profile from PR CI job.

@yesamer
Copy link
Member Author

yesamer commented Jul 15, 2024

Jenkins run cdb

1 similar comment
@yesamer
Copy link
Member Author

yesamer commented Jul 15, 2024

Jenkins run cdb

@gitgabrio
Copy link

Jenkins retest this

@yesamer
Copy link
Member Author

yesamer commented Jul 15, 2024

Jenkins run fdb

1 similar comment
@yesamer
Copy link
Member Author

yesamer commented Jul 15, 2024

Jenkins run fdb

@yesamer
Copy link
Member Author

yesamer commented Jul 16, 2024

Pull Request failed because of an unrelated failure (sonar checks). Merging

@yesamer yesamer merged commit 5892bca into kiegroup:7.67.x-blue Jul 16, 2024
6 of 7 checks passed
@yesamer yesamer deleted the 7.67.x-blue-improve_import_messages branch July 16, 2024 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-7.67.x-blue Generate backport PR for 7.67.x-blue branch
Projects
None yet
4 participants