Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.101.x-prod] Enhance ConstraintOperator capability (#6104) #81

Conversation

tkobayas
Copy link

@tkobayas tkobayas commented Oct 11, 2024

  • [DROOLS-7635] ansible-rulebook : Raise an error when a condition compares incompatible types

    • Add beta index support
  • Add unit test
  • changed method names

Ports
This is a backport PR of 83e0465 for 9.101.x-prod

JIRA:

Need this commit for https://issues.redhat.com/browse/DROOLS-7635

* [DROOLS-7635] ansible-rulebook : Raise an error when a condition compares incompatible types

* - Add beta index support
- Add unit test

* changed method names
@tkobayas
Copy link
Author

Hmm, I have no idea why jenkins fails.

@tkobayas tkobayas changed the title Enhance ConstraintOperator capability (#6104) [9.101.x-prod] Enhance ConstraintOperator capability (#6104) Oct 11, 2024
@mareknovotny
Copy link
Member

jenkins retest this

@rgdoliveira
Copy link
Member

I guess we can trust in the GHA checks and if they are green, we are safe. I have just one concern about PRs now on 9.101.x-prod branch and I raised it in slack, so we can better discuss.

@tkobayas
Copy link
Author

@rgdoliveira Sure, let's discuss on slack.

@rgdoliveira rgdoliveira merged commit d586e9a into kiegroup:9.101.x-prod Oct 17, 2024
4 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants