Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JBPM-10176] Detect creation of timers for notifications #2283

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

albfan
Copy link
Contributor

@albfan albfan commented May 5, 2023

JBPM-10176

needs:

Add a TimerJobContext to detect if a job is just created to not look for it in existing timers

The problem is only noticeable if you have lot of timers and creates a new notifications.

The interface allow any other job creating timers to control this behaviour.

@gmunozfe
Copy link
Member

gmunozfe commented May 5, 2023

jenkins retest this

Copy link
Contributor

@fjtirado fjtirado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @albfan

@fjtirado
Copy link
Contributor

jenkins retest this

1 similar comment
@fjtirado
Copy link
Contributor

jenkins retest this

@fjtirado
Copy link
Contributor

@gmunozfe Seems that this CI is not taken the Drools PR and hence compilation is failing, any clue why this might happen. The branches seems to have the same name.

@albfan
Copy link
Contributor Author

albfan commented Jun 8, 2023

@fjtirado Cannot create a JBPM issue. associated PR are rebased to 7.x branch

@albfan albfan changed the title [RHPAM-4698] Detect creation of timers for notifications [JBPM-10176] Detect creation of timers for notifications Jun 8, 2023
@fjtirado fjtirado reopened this Jun 8, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jun 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@fjtirado fjtirado merged commit 2890808 into kiegroup:main Jul 6, 2023
fjtirado pushed a commit to fjtirado/jbpm that referenced this pull request Aug 17, 2023
Co-authored-by: Alberto Fanjul <afanjula@redhat.com>
fjtirado pushed a commit to fjtirado/jbpm that referenced this pull request Sep 15, 2023
Co-authored-by: Alberto Fanjul <afanjula@redhat.com>
fjtirado pushed a commit to fjtirado/jbpm that referenced this pull request Sep 15, 2023
Co-authored-by: Alberto Fanjul <afanjula@redhat.com>
fjtirado pushed a commit to fjtirado/jbpm that referenced this pull request Nov 7, 2023
Co-authored-by: Alberto Fanjul <afanjula@redhat.com>
@mareknovotny mareknovotny added the backport-7.67.x Generate backport PR for 7.67.x branch label Jan 8, 2024
@mareknovotny mareknovotny added the backport-7.67.x-blue Generate backport PR for 7.67.x-blue branch label Jan 8, 2024
github-actions bot pushed a commit that referenced this pull request Jan 8, 2024
Co-authored-by: Alberto Fanjul <afanjula@redhat.com>
github-actions bot pushed a commit that referenced this pull request Jan 8, 2024
Co-authored-by: Alberto Fanjul <afanjula@redhat.com>
@fjtirado fjtirado added backport-7.67.x Generate backport PR for 7.67.x branch backport-7.67.x-blue Generate backport PR for 7.67.x-blue branch and removed backport-7.67.x Generate backport PR for 7.67.x branch backport-7.67.x-blue Generate backport PR for 7.67.x-blue branch labels Jan 9, 2024
github-actions bot pushed a commit that referenced this pull request Jan 9, 2024
Co-authored-by: Alberto Fanjul <afanjula@redhat.com>
github-actions bot pushed a commit that referenced this pull request Jan 9, 2024
Co-authored-by: Alberto Fanjul <afanjula@redhat.com>
fjtirado pushed a commit that referenced this pull request Jan 9, 2024
Co-authored-by: Alberto Fanjul <albertofanjul@gmail.com>
Co-authored-by: Alberto Fanjul <afanjula@redhat.com>
fjtirado pushed a commit that referenced this pull request Jan 9, 2024
Co-authored-by: Alberto Fanjul <albertofanjul@gmail.com>
Co-authored-by: Alberto Fanjul <afanjula@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-7.67.x Generate backport PR for 7.67.x branch backport-7.67.x-blue Generate backport PR for 7.67.x-blue branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants