Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[incubator-kie-issues-645] potential fix for orphans #2348

Merged

Conversation

elguardian
Copy link
Member

@elguardian elguardian commented Oct 20, 2023

apache/incubator-kie-issues#645

trigger the listeners and timer removal event if the timer was not registered in this node.

@sonarcloud
Copy link

sonarcloud bot commented Oct 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@elguardian elguardian changed the title [incubator-kie-issues-597-orphans] potential fix for orphans [https://github.com/apache/incubator-kie-issues/issues/645] potential fix for orphans Oct 24, 2023
@elguardian elguardian changed the title [https://github.com/apache/incubator-kie-issues/issues/645] potential fix for orphans [incubator-kie-issues-645] potential fix for orphans Oct 24, 2023
@gmunozfe
Copy link
Member

@elguardian could you add the labels for 7.67.x and 7.67.x-blue automatic backporting? Thanks!

@martinweiler martinweiler added backport-7.67.x Generate backport PR for 7.67.x branch backport-7.67.x-blue Generate backport PR for 7.67.x-blue branch labels Oct 27, 2023
Copy link
Member

@gmunozfe gmunozfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, well done @elguardian

@mareknovotny
Copy link
Member

any objection to merge it? @fjtirado

@mareknovotny
Copy link
Member

ok, there is no FDB result check

jenkins do fdb

@elguardian
Copy link
Member Author

failures not related.

@elguardian elguardian merged commit b3f8fec into kiegroup:main Jan 11, 2024
9 of 10 checks passed
@elguardian elguardian deleted the incubator-kie-issues-597-listener branch January 11, 2024 08:18
mareknovotny pushed a commit that referenced this pull request Jan 18, 2024
…2382)

Co-authored-by: Enrique <enrique.gonzalez.martinez1@ibm.com>
mareknovotny pushed a commit that referenced this pull request Jan 18, 2024
…2381)

Co-authored-by: Enrique <enrique.gonzalez.martinez1@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-7.67.x Generate backport PR for 7.67.x branch backport-7.67.x-blue Generate backport PR for 7.67.x-blue branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants