Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JBPM-10208] Signalling engine only once #2359

Merged
merged 3 commits into from
Nov 10, 2023
Merged

Conversation

fjtirado
Copy link
Contributor

@fjtirado fjtirado commented Nov 7, 2023

This keeps track of the engines that has already being signalled to avoid signalling the same engine twice as part of the same signalEvent call.

@fjtirado fjtirado marked this pull request as ready for review November 8, 2023 12:40
@fjtirado
Copy link
Contributor Author

fjtirado commented Nov 8, 2023

jenkins retest this

Copy link

sonarcloud bot commented Nov 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

90.0% 90.0% Coverage
0.0% 0.0% Duplication

@elguardian
Copy link
Member

I need more context about this one. Don't really understand the background or have a test case.

@fjtirado fjtirado added backport-7.67.x Generate backport PR for 7.67.x branch backport-7.67.x-blue Generate backport PR for 7.67.x-blue branch labels Nov 10, 2023
Copy link
Member

@gmunozfe gmunozfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, effective solution though I was also wondering why is happening this duplication. A test can be added later as we verified with the reproducer that fixes the issue. Fantastic work @fjtirado !

@fjtirado fjtirado merged commit f897fcc into kiegroup:main Nov 10, 2023
8 of 11 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 10, 2023
* [JBPM-10208] Signalling engine only once

* [JBPM-10208] Alternative approach

* Revert "[JBPM-10208] Alternative approach"

This reverts commit 44b1751.
github-actions bot pushed a commit that referenced this pull request Nov 10, 2023
* [JBPM-10208] Signalling engine only once

* [JBPM-10208] Alternative approach

* Revert "[JBPM-10208] Alternative approach"

This reverts commit 44b1751.
fjtirado added a commit that referenced this pull request Nov 20, 2023
* [JBPM-10208] Signalling engine only once (#2359)

* [JBPM-10208] Signalling engine only once

* [JBPM-10208] Alternative approach

* Revert "[JBPM-10208] Alternative approach"

This reverts commit 44b1751.

* Update PerProcessInstanceRuntimeManager.java

---------

Co-authored-by: Francisco Javier Tirado Sarti <65240126+fjtirado@users.noreply.github.com>
fjtirado added a commit that referenced this pull request Nov 20, 2023
* [JBPM-10208] Signalling engine only once (#2359)

* [JBPM-10208] Signalling engine only once

* [JBPM-10208] Alternative approach

* Revert "[JBPM-10208] Alternative approach"

This reverts commit 44b1751.

* Update PerProcessInstanceRuntimeManager.java

---------

Co-authored-by: Francisco Javier Tirado Sarti <65240126+fjtirado@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-7.67.x Generate backport PR for 7.67.x branch backport-7.67.x-blue Generate backport PR for 7.67.x-blue branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants