-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JBPM-10208] Signalling engine only once #2359
Conversation
This reverts commit 44b1751.
jenkins retest this |
Kudos, SonarCloud Quality Gate passed! |
I need more context about this one. Don't really understand the background or have a test case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, effective solution though I was also wondering why is happening this duplication. A test can be added later as we verified with the reproducer that fixes the issue. Fantastic work @fjtirado !
* [JBPM-10208] Signalling engine only once * [JBPM-10208] Alternative approach * Revert "[JBPM-10208] Alternative approach" This reverts commit 44b1751.
* [JBPM-10208] Signalling engine only once * [JBPM-10208] Alternative approach * Revert "[JBPM-10208] Alternative approach" This reverts commit 44b1751.
* [JBPM-10208] Signalling engine only once (#2359) * [JBPM-10208] Signalling engine only once * [JBPM-10208] Alternative approach * Revert "[JBPM-10208] Alternative approach" This reverts commit 44b1751. * Update PerProcessInstanceRuntimeManager.java --------- Co-authored-by: Francisco Javier Tirado Sarti <65240126+fjtirado@users.noreply.github.com>
* [JBPM-10208] Signalling engine only once (#2359) * [JBPM-10208] Signalling engine only once * [JBPM-10208] Alternative approach * Revert "[JBPM-10208] Alternative approach" This reverts commit 44b1751. * Update PerProcessInstanceRuntimeManager.java --------- Co-authored-by: Francisco Javier Tirado Sarti <65240126+fjtirado@users.noreply.github.com>
This keeps track of the engines that has already being signalled to avoid signalling the same engine twice as part of the same signalEvent call.