Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JBPM-10225] Considering time for Dates #2397

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Conversation

fjtirado
Copy link
Contributor

@fjtirado fjtirado commented Mar 13, 2024

Adding a new date format and proper test

JIRA:

link

@fjtirado fjtirado requested a review from gmunozfe March 13, 2024 09:37
@fjtirado
Copy link
Contributor Author

jenkins run fdb

@fjtirado fjtirado added backport-7.67.x Generate backport PR for 7.67.x branch backport-7.67.x-blue Generate backport PR for 7.67.x-blue branch labels Mar 13, 2024
Copy link
Member

@gmunozfe gmunozfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just a proposal to add also a format with blank in the middle

@fjtirado fjtirado requested a review from gmunozfe March 13, 2024 10:36
Copy link

sonarcloud bot commented Mar 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@gmunozfe
Copy link
Member

downstream test failure unrelated:

[org.kie.server.springboot.samples.KeycloakKieServerTest.org.kie.server.springboot.samples.KeycloakKieServerTest]
Caused by: javax.ws.rs.NotAuthorizedException: HTTP 401 Unauthorized

@fjtirado fjtirado merged commit 9e77a4f into kiegroup:main Mar 14, 2024
6 of 9 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 14, 2024
github-actions bot pushed a commit that referenced this pull request Mar 14, 2024
fjtirado added a commit that referenced this pull request Mar 18, 2024
Co-authored-by: Francisco Javier Tirado Sarti <65240126+fjtirado@users.noreply.github.com>
fjtirado added a commit that referenced this pull request Mar 18, 2024
Co-authored-by: Francisco Javier Tirado Sarti <65240126+fjtirado@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-7.67.x Generate backport PR for 7.67.x branch backport-7.67.x-blue Generate backport PR for 7.67.x-blue branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants