avoid race condition for awaiting signals and process instance completed #2403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elguardian
force-pushed
the
incubator-kie-issues-1016
branch
from
e8834bc
to
51536cf
Compare
martinweiler
requested changes
Mar 20, 2024
| } | ||
| } catch (org.drools.persistence.api.SessionNotFoundException ex) { |
There was a problem hiding this comment.
This needs to catch org.kie.internal.runtime.manager.SessionNotFoundException in my tests:
ERROR [org.kie.server.services.jbpm.kafka.KafkaServerConsumer] (pool-18-thread-10) Exception deserializing event: org.kie.internal.runtime.manager.SessionNotFoundException: No session found for context 143
at org.jbpm.runtime.manager.impl.PerProcessInstanceRuntimeManager$PerProcessInstanceInitializer.initKieSession(PerProcessInstanceRuntimeManager.java:584)
at org.jbpm.runtime.manager.impl.RuntimeEngineImpl.internalGetKieSession(RuntimeEngineImpl.java:169)
at org.jbpm.runtime.manager.impl.RuntimeEngineImpl.getKieSession(RuntimeEngineImpl.java:76)
at org.jbpm.runtime.manager.impl.PerProcessInstanceRuntimeManager.signalEvent(PerProcessInstanceRuntimeManager.java:186)
at org.jbpm.kie.services.impl.ProcessServiceImpl.signalEvent(ProcessServiceImpl.java:383)
| } | ||
| } catch (org.drools.persistence.api.SessionNotFoundException ex) { | ||
| logger.warn("Signal event cannot proceed because of session not found exception {} for engine {}", ex.getMessage(), runtimeEngine.getKieSessionId()); |
There was a problem hiding this comment.
I see this getting logged frequently and think it would be better to have it at DEBUG level.
… and process instance completed
elguardian
force-pushed
the
incubator-kie-issues-1016
branch
from
51536cf
to
3957069
Compare
|
martinweiler
approved these changes
Mar 21, 2024
elguardian
added
the
backport-7.67.x-blue
github-actions bot
pushed a commit
that referenced
this pull request
Mar 21, 2024
… and process instance completed (#2403)
elguardian
added a commit
to elguardian/jbpm
that referenced
this pull request
Mar 21, 2024
… and process instance completed (kiegroup#2403)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: https://github.com/apache/incubator-kie-issues-1016